Skip to content

Commit

Permalink
Fix task ordering in rolling upgrade tests
Browse files Browse the repository at this point in the history
The configuration of the upgraded cluster task was missing a dependency
on the stopping of the second old node in the cluster. In some cases
(e.g., --parallel) Gradle would then try to run the configuration of a
node in the upgraded cluster before it had even configured the old nodes
in the cluster.

Relates #28036
  • Loading branch information
jasontedor authored Jan 9, 2018
1 parent 8ceae2a commit ccaba01
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions qa/rolling-upgrade/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,10 @@ for (Version version : versionCollection.versionsWireCompatibleWithCurrent) {
finalizedBy "${baseName}#oldClusterTestCluster#node0.stop"
}

Task upgradedClusterTest = tasks.create(name: "${baseName}#upgradedClusterTest", type: RestIntegTestTask) {
dependsOn(mixedClusterTestRunner, "${baseName}#oldClusterTestCluster#node0.stop")
}
Task upgradedClusterTest = tasks.create(name: "${baseName}#upgradedClusterTest", type: RestIntegTestTask)

configure(extensions.findByName("${baseName}#upgradedClusterTestCluster")) {
dependsOn mixedClusterTestRunner, "${baseName}#oldClusterTestCluster#node0.stop"
distribution = 'zip'
clusterName = 'rolling-upgrade'
unicastTransportUri = { seedNode, node, ant -> mixedClusterTest.nodes.get(0).transportUri() }
Expand Down

0 comments on commit ccaba01

Please sign in to comment.