BlobStoreCacheMaintenanceService.PeriodicMaintenanceTask should not hold a reference to a SearchResponse #103245
Labels
:Distributed/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
Team:Distributed
Meta label for distributed team
>tech debt
Comments
original-brownbear
added
:Distributed/Snapshot/Restore
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this issue
Dec 13, 2023
Today the `PeriodicMaintenanceTask` includes several mutable fields whose values determine what stage of the computation is currently active, so that the task can re-invoke itself to run each stage. This is pretty confusing and doesn't play very nicely with refcounting the search responses. With this commit we rework the task to avoid these mutable fields and clarify how it executes. Relates elastic#103245
elasticsearchmachine
pushed a commit
that referenced
this issue
Dec 14, 2023
Today the `PeriodicMaintenanceTask` includes several mutable fields whose values determine what stage of the computation is currently active, so that the task can re-invoke itself to run each stage. This is pretty confusing and doesn't play very nicely with refcounting the search responses. With this commit we rework the task to avoid these mutable fields and clarify how it executes. Relates #103245
|
#103383 resolves this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From the discussion in #103118 and motivated by the fact that
SearchResponsewill be ref-counted soon.BlobStoreCacheMaintenanceService.PeriodicMaintenanceTaskcurrently holds a reference to aSearchResponsein a field.This seems unnecessary and can be refactored to make it so that the search response is only held in a local variable, removing the need for tricky ref-counting on it -> remove that reference to resolve this issue.
The text was updated successfully, but these errors were encountered: