Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata to configuration exceptions #27728

Closed
DaveCTurner opened this issue Dec 8, 2017 · 0 comments · Fixed by #32322
Closed

Add metadata to configuration exceptions #27728

DaveCTurner opened this issue Dec 8, 2017 · 0 comments · Fixed by #32322
Assignees
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement help wanted adoptme

Comments

@DaveCTurner
Copy link
Contributor

... instead of using headers.

Similarly to #27724, there is some exception metadata that is included in headers rather than using addMetadata(), introduced in #19318.

if (processorType != null) {
exception.addHeader("processor_type", processorType);
}
if (processorTag != null) {
exception.addHeader("processor_tag", processorTag);
}
if (propertyName != null) {
exception.addHeader("property_name", propertyName);
}

Under the umbrella of #27672, it'd be preferable to use addMetadata() to reduce the number of ways that clients have to handle errors.

/cc @simonw and @talevy for further opinions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement help wanted adoptme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants