Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Consistency between LIKE pattern and table pattern #33294

Closed
costin opened this issue Aug 31, 2018 · 1 comment · Fixed by #33363
Closed

SQL: Consistency between LIKE pattern and table pattern #33294

costin opened this issue Aug 31, 2018 · 1 comment · Fixed by #33363
Labels
:Analytics/SQL SQL querying >enhancement v6.5.0 v7.0.0-beta1

Comments

@costin
Copy link
Member

costin commented Aug 31, 2018

Through #33278, the tableIdentifier has been extended to allow ES-like multi-index patterns. However this is not supported by all commands, such as SHOW TABLES which only allow SQL LIKE pattern.
Both should be supported across the board for consistency and also capabilities so :
SHOW TABLES LIKE "foo%" and SHOW TABLES 'foo*,-foobar* work.

(note that while SQL LIKE only allows inclusion, ES allows exclusion also).
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@costin costin mentioned this issue Sep 3, 2018
Merged
costin added a commit to costin/elasticsearch that referenced this issue Sep 4, 2018
@costin
SQL: Show/desc commands now support table ids
c8e7cd1 
Extend SHOW TABLES, DESCRIBE and SHOW COLUMNS to support table
identifiers not just SQL LIKE pattern.
This allows both Elasticsearch-style multi-index patterns and SQL LIKE.
To disambiguate between the two (as the " vs ' can be easy to miss),
the grammar now requires LIKE keyword as a prefix for all LIKE-like
patterns.

Also added some docs comparing the two types of patterns.

Fix elastic#33294
costin added a commit that referenced this issue Sep 4, 2018
@costin
SQL: Show/desc commands now support table ids (#33363)
17c7f99 
Extend SHOW TABLES, DESCRIBE and SHOW COLUMNS to support table
identifiers not just SQL LIKE pattern.
This allows both Elasticsearch-style multi-index patterns and SQL LIKE.
To disambiguate between the two (as the " vs ' can be easy to miss),
the grammar now requires LIKE keyword as a prefix for all LIKE-like
patterns.

Also added some docs comparing the two types of patterns.

Fix #33294
costin added a commit that referenced this issue Sep 4, 2018
@costin
SQL: Show/desc commands now support table ids (#33363)
ad5a9b5 
Extend SHOW TABLES, DESCRIBE and SHOW COLUMNS to support table
identifiers not just SQL LIKE pattern.
This allows both Elasticsearch-style multi-index patterns and SQL LIKE.
To disambiguate between the two (as the " vs ' can be easy to miss),
the grammar now requires LIKE keyword as a prefix for all LIKE-like
patterns.

Also added some docs comparing the two types of patterns.

Fix #33294

(cherry picked from commit 17c7f99)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >enhancement v6.5.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SQL: Show/desc commands now support table ids costin/elasticsearch
3 participants
@costin @colings86 @elasticmachine