SQL: Separate ProcessDefinition and ScriptTemplate from functions #33975
Labels
Comments
|
Pinging @elastic/es-search-aggs |
costin
added a commit
to costin/elasticsearch
that referenced
this issue
Sep 26, 2018
Rename ProcessDefinition to Pipe Add asScript / asPipe onto Expression (might be pushed further down) Add ScriptWeaver as a mixin-in interface for script customization Add logic for equals/lte/lt Improve BinaryOperator/expression toString Minimize duplication across string functions Close elastic#33975
costin
added a commit
that referenced
this issue
Sep 27, 2018
Centralize and simplify the script generation between operators and functions which are currently decoupled. As part of this process most predicates (<, <=, etc...) were made ScalarFunction as their purpose and functionality is quite similar (see % and MOD functions). Renamed ProcessDefinition to Pipe Add ScriptWeaver as a mixin-in interface for script customization Add logic for equals/lte/lt Improve BinaryOperator/expression toString Minimize duplication across string functions Close #33975
costin
added a commit
that referenced
this issue
Sep 27, 2018
Centralize and simplify the script generation between operators and functions which are currently decoupled. As part of this process most predicates (<, <=, etc...) were made ScalarFunction as their purpose and functionality is quite similar (see % and MOD functions). Renamed ProcessDefinition to Pipe Add ScriptWeaver as a mixin-in interface for script customization Add logic for equals/lte/lt Improve BinaryOperator/expression toString Minimize duplication across string functions Close #33975 (cherry picked from commit 15515a6)
kcm
pushed a commit
that referenced
this issue
Oct 30, 2018
Centralize and simplify the script generation between operators and functions which are currently decoupled. As part of this process most predicates (<, <=, etc...) were made ScalarFunction as their purpose and functionality is quite similar (see % and MOD functions). Renamed ProcessDefinition to Pipe Add ScriptWeaver as a mixin-in interface for script customization Add logic for equals/lte/lt Improve BinaryOperator/expression toString Minimize duplication across string functions Close #33975
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When first introduced,
ProcessDefinitionandScriptTemplatewere part ofScalarFunctionhowever the concept proved to me much more generic.For example arithmetic operators were transformed into functions (despite not being one); the same situation needs to be applied with the rest of the operators, namely the comparison and some predicates (Like/RLike).
In fact, most (if not all) expressions require these as they can appear both on the invoking node and inside a script.
The text was updated successfully, but these errors were encountered: