Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest should ignore empty shards #3473

Closed
dadoonet opened this issue Aug 9, 2013 · 4 comments
Closed

Suggest should ignore empty shards #3473

dadoonet opened this issue Aug 9, 2013 · 4 comments
Assignees
@dadoonet
Labels
>enhancement v0.90.4 v1.0.0.Beta1

Comments

@dadoonet
Copy link
Member

dadoonet commented Aug 9, 2013

From #3469.
When running suggest on empty shards, it raises an error like:

"failures" : [ {
      "status" : 400,
      "reason" : "ElasticSearchIllegalArgumentException[generator field [title] doesn't exist]"
    } ]

We should ignore empty shards.
@ghost ghost assigned dadoonet Aug 9, 2013
This was referenced Aug 9, 2013
Closed
Closed
@s1monw
Copy link
Contributor

s1monw commented Aug 14, 2013

@dadoonet what's the status of this?

@dadoonet
Copy link
Member Author

Sorry Simon. Did not find time to integrate your comments. Will do before the end of this week.

@s1monw
Copy link
Contributor

s1monw commented Aug 14, 2013

thanks @dadoonet

dadoonet added a commit to dadoonet/elasticsearch that referenced this issue Aug 16, 2013
@dadoonet
Suggest should ignore empty shards
3b717f2 
From elastic#3469.
When running suggest on empty shards, it raises an error like:

```
"failures" : [ {
      "status" : 400,
      "reason" : "ElasticSearchIllegalArgumentException[generator field [title] doesn't exist]"
    } ]
```

We should ignore empty shards.

Closes elastic#3473.
@dadoonet
Copy link
Member Author

@s1monw I created an AbstractSuggester class and kept the Suggester interface. Ok with that?

dadoonet added a commit that referenced this issue Aug 16, 2013
@dadoonet
Suggest should ignore empty shards
2836eeb 
From #3469.
When running suggest on empty shards, it raises an error like:

```
"failures" : [ {
      "status" : 400,
      "reason" : "ElasticSearchIllegalArgumentException[generator field [title] doesn't exist]"
    } ]
```

We should ignore empty shards.

Closes #3473.
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@dadoonet
Suggest should ignore empty shards
517af7f 
From elastic#3469.
When running suggest on empty shards, it raises an error like:

```
"failures" : [ {
      "status" : 400,
      "reason" : "ElasticSearchIllegalArgumentException[generator field [title] doesn't exist]"
    } ]
```

We should ignore empty shards.

Closes elastic#3473.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dadoonet dadoonet

Labels
>enhancement v0.90.4 v1.0.0.Beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Suggest should ignore empty shards dadoonet/elasticsearch
2 participants
@dadoonet @s1monw