Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore Multiple Data Paths for 8.0 #78525

Closed
17 tasks done
rjernst opened this issue Sep 30, 2021 · 2 comments
Closed
17 tasks done

Restore Multiple Data Paths for 8.0 #78525

rjernst opened this issue Sep 30, 2021 · 2 comments
Labels
:Core/Infra/Core Core issues without another label Meta Team:Core/Infra Meta label for core/infra team v8.0.0-beta1

Comments

@rjernst
Copy link
Member

rjernst commented Sep 30, 2021 •
edited
Loading

Multiple Data Paths (MDP) was deprecated in 7.13.0, and then removed from the master branch several months ago (see #71205). This is a meta issue for restoring MDP for 8.0, to provide a longer deprecation period. The following commits need to be reverted, in order:

Also need to apply this fix:
@rjernst rjernst added :Core/Infra/Core Core issues without another label Meta v8.0.0 labels Sep 30, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Sep 30, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@grcevski grcevski pinned this issue Oct 1, 2021
@grcevski grcevski unpinned this issue Oct 1, 2021
rjernst added a commit to rjernst/elasticsearch that referenced this issue Oct 4, 2021
@rjernst
Revert "Remove multiple paths from elasticsearch-node tool (elastic#7…
62f3462 
…2351)"

This reverts commit 619a011.

relates elastic#78525
relates elastic#71205
@rjernst rjernst mentioned this issue Oct 4, 2021
Merged
@DaveCTurner DaveCTurner mentioned this issue Oct 4, 2021
Merged
elasticsearchmachine pushed a commit that referenced this issue Oct 4, 2021
@rjernst
Revert "Remove multiple paths from elasticsearch-node tool (#72351)" (#…
cfcc187 
…78636)

This reverts commit 619a011.

relates #78525
relates #71205
rjernst added a commit to rjernst/elasticsearch that referenced this issue Oct 4, 2021
@rjernst
Revert "Remove multiple paths from NodeEnvironment (elastic#72599)"
2460eac 
This reverts commit b6436c5.

The revert had no merge conflicts.

relates elastic#78525
relates elastic#71205
@rjernst rjernst mentioned this issue Oct 4, 2021
Merged
rjernst added a commit that referenced this issue Oct 5, 2021
@rjernst
Revert "Remove multiple paths from NodeEnvironment (#72599)" (#78655)
b5b73ed 
This reverts commit b6436c5.

The revert had no merge conflicts.

relates #78525
relates #71205
rjernst added a commit to rjernst/elasticsearch that referenced this issue Oct 5, 2021
@rjernst
Revert "Make NodeEnvironment.resolveIndexFolder singular (elastic#72515…
33a7ada 
…)"

This reverts commit 7a05d72.

The revert had no merge conflicts.

relates elastic#78525
relates elastic#71205
@rjernst rjernst mentioned this issue Oct 5, 2021
Merged
rjernst added a commit that referenced this issue Oct 6, 2021
@rjernst
Revert "Make NodeEnvironment.resolveIndexFolder singular (#72515)" (#…
c100829 
…78702)

This reverts commit 7a05d72.

The revert had no merge conflicts.

relates #78525
relates #71205
rjernst added a commit to rjernst/elasticsearch that referenced this issue Oct 6, 2021
@rjernst
Revert "Make nodePaths() singular (elastic#72514)"
a99032f 
This reverts commit 2dc796a.

The revert was mostly clean, but it required adjusting
NodeEnvironment.upgradeLegacyNodeFolders to retain elastic#74921.

relates elastic#78525
relates elastic#71205
@rjernst rjernst mentioned this issue Oct 6, 2021
Merged
rjernst added a commit that referenced this issue Oct 7, 2021
@rjernst
Revert "Make nodePaths() singular (#72514)" (#78801)
2fe2c80 
This reverts commit 2dc796a.

The revert was mostly clean, but it required adjusting
NodeEnvironment.upgradeLegacyNodeFolders to retain #74921.

relates #78525
relates #71205
rjernst added a commit to rjernst/elasticsearch that referenced this issue Oct 7, 2021
@rjernst
Revert "Make NodeEnvironment.nodeDataPaths singular (elastic#72432)"
af08cb5 
This reverts commit 6a7298e.

The revert was not clean. There were two adjustements necessary.
First, this effectively must revert elastic#73136. Second, some tests
were written after MDP removal so needed to be made multi path aware.

relates elastic#78525
relates elastic#71205
@rjernst rjernst mentioned this issue Oct 7, 2021
Merged
@DaveCTurner DaveCTurner mentioned this issue Oct 11, 2021
Merged
rjernst added a commit that referenced this issue Oct 11, 2021
@rjernst
Revert "Make NodeEnvironment.nodeDataPaths singular (#72432)" (#78861)
5744ed5 
This reverts commit 6a7298e.

The revert was not clean. There were two adjustements necessary.
First, this effectively must revert #73136. Second, some tests
were written after MDP removal so needed to be made multi path aware.

relates #78525
relates #71205
rjernst added a commit to rjernst/elasticsearch that referenced this issue Oct 11, 2021
@rjernst
Revert "Convert index path listeners to single path (elastic#72511)"
40ee715 
This reverts commit fd138f5.

The revert was effectively conflict free, there was only a very minor
static import that needed fixing.

relates elastic#78525
relates elastic#71205
@rjernst rjernst mentioned this issue Oct 11, 2021
Merged
rjernst added a commit that referenced this issue Oct 11, 2021
@rjernst
Revert "Convert index path listeners to single path (#72511)" (#78935)
03a4577 
This reverts commit fd138f5.

The revert was effectively conflict free, there was only a very minor
static import that needed fixing.

relates #78525
relates #71205
rjernst added a commit to rjernst/elasticsearch that referenced this issue Oct 11, 2021
@rjernst
Revert "Move the MDP error check into Environment (elastic#72498)"
d123110 
This reverts commit 8602688.

The revert was conflict free.

relates elastic#78525
relates elastic#71205
@rjernst rjernst mentioned this issue Oct 11, 2021
Merged
rjernst added a commit that referenced this issue Oct 12, 2021
@rjernst
Revert "Move the MDP error check into Environment (#72498)" (#78945)
d7e6d9e 
This reverts commit 8602688.

The revert was conflict free.

relates #78525
relates #71205
rjernst added a commit to rjernst/elasticsearch that referenced this issue Oct 12, 2021
@rjernst
Revert "Make NodeEnvironment.availableShardPaths singular (elastic#72441
a199e13 
)"

This reverts commit faede0a.

This revert was conflict free.

relates elastic#78525
relates elastic#71205
@rjernst rjernst mentioned this issue Oct 12, 2021
Merged
rjernst added a commit that referenced this issue Oct 12, 2021
@rjernst
Revert "Make NodeEnvironment.availableShardPaths singular (#72441)" (#…
2cb444c 
…78985)

This reverts commit faede0a.

This revert was conflict free.

relates #78525
relates #71205
rjernst added a commit to rjernst/elasticsearch that referenced this issue Oct 12, 2021
@rjernst
Revert "Make NodeEnvironment.indexPaths singular (elastic#72438)"
85234fd 
This reverts commit 2a446ad.

This revert was conflict free.

relates elastic#78525
relates elastic#71205
@rjernst rjernst mentioned this issue Oct 12, 2021
Merged
rjernst added a commit that referenced this issue Oct 13, 2021
@rjernst
Revert "Make NodeEnvironment.indexPaths singular (#72438)" (#79011)
ea19dcd 
This reverts commit 2a446ad.

This revert was conflict free.

relates #78525
relates #71205
rjernst added a commit to rjernst/elasticsearch that referenced this issue Oct 13, 2021
@rjernst
Revert "Make Environment.dataFiles singular (elastic#72327)"
6e55863 
This reverts commit b1eab79.

This revert was conflict free.

relates elastic#78525
relates elastic#71205
@rjernst rjernst mentioned this issue Oct 13, 2021
Merged
rjernst added a commit that referenced this issue Oct 13, 2021
@rjernst
Revert "Make Environment.dataFiles singular (#72327)" (#79028)
aa11f0f 
This reverts commit b1eab79.

This revert was conflict free.

relates #78525
relates #71205
rjernst added a commit to rjernst/elasticsearch that referenced this issue Oct 13, 2021
@rjernst
Revert "Convert path.data to String setting instead of List (elastic#…
2d377df 
…72282)"

This reverts commit d933ecd.

The revert had two conflicts. The first was very minor in JoinHelper.
The second was several tests in PersistedClusterStateServiceTests.

relates elastic#78525
relates elastic#71205
@rjernst rjernst mentioned this issue Oct 13, 2021
Merged
rjernst added a commit that referenced this issue Oct 14, 2021
@rjernst
Revert "Convert path.data to String setting instead of List (#72282)" (…
d97d282 
…#79091)

This reverts commit d933ecd.

The revert had two conflicts. The first was very minor in JoinHelper.
The second was several tests in PersistedClusterStateServiceTests.

relates #78525
relates #71205
rjernst added a commit to rjernst/elasticsearch that referenced this issue Oct 14, 2021
@rjernst
Revert "Fail when using multiple data paths (elastic#72184)"
48cae8c 
This reverts commit 6aa0735.

This revert was conflict free.

relates elastic#78525
relates elastic#71205
@rjernst rjernst mentioned this issue Oct 14, 2021
Merged
@DaveCTurner DaveCTurner mentioned this issue Oct 14, 2021
Merged
rjernst added a commit that referenced this issue Oct 15, 2021
@rjernst
Revert "Fail when using multiple data paths (#72184)" (#79116)
8c37255 
This reverts commit 6aa0735.

This revert was conflict free.

relates #78525
relates #71205
@rjernst
Copy link
Member Author

rjernst commented Oct 18, 2021

Multiple Data Paths are now supported again in 8.0.

@rjernst rjernst closed this as completed Oct 18, 2021
@david-kow david-kow mentioned this issue Oct 28, 2021
Open
@grcevski grcevski mentioned this issue Dec 2, 2021
Merged
@pugnascotia pugnascotia mentioned this issue Feb 9, 2022
Merged
@barkbay barkbay mentioned this issue May 24, 2022
Merged
@BlackMetalz BlackMetalz mentioned this issue May 25, 2023
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Core/Infra/Core Core issues without another label Meta Team:Core/Infra Meta label for core/infra team v8.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rjernst @jakelandis @elasticmachine