Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix system property value for inference rescorer tests feature flag #100366

Merged

Conversation

mark-vieira
Copy link
Contributor

@mark-vieira mark-vieira commented Oct 5, 2023

Follow up to #100301 to fix the missing system property value for this feature flag.

Closes #100362

@mark-vieira mark-vieira added >non-issue :Delivery/Build Build or test infrastructure auto-backport-and-merge Automatically create backport pull requests and merge when ready v8.11.1 v8.10.4 labels Oct 5, 2023
@elasticsearchmachine elasticsearchmachine added Team:Delivery Meta label for Delivery team v8.12.0 labels Oct 5, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@mark-vieira
Copy link
Contributor Author

@elasticmachine update branch

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@breskeby breskeby merged commit 350720e into elastic:main Oct 6, 2023
10 of 11 checks passed
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Oct 6, 2023
…lastic#100366)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.11
8.10 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 100366

elasticsearchmachine pushed a commit that referenced this pull request Oct 6, 2023
…100366) (#100390)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Oct 9, 2023
…lastic#100366)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	test/test-clusters/src/main/java/org/elasticsearch/test/cluster/FeatureFlag.java
@mark-vieira mark-vieira deleted the fix-inference-rescorer-feature-flag branch October 9, 2023 17:31
@andreidan
Copy link
Contributor

This was backported with #100532

Removing the backport pending label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready :Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v8.10.4 v8.11.1 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] XPackRestIT test {p0=ml/inference_rescore/Test rescore with missing model} failing
6 participants