Fixing AsyncStatusResponseTests#testGetStatusFromStoredSearchWithNonEmptyClustersStillRunning #100812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hin testGetStatusFromStoredSearchWithNonEmptyClustersStillRunning to pass the needed test assertion
pmpailis
added
>test
|
Pinging @elastic/es-search (Team:Search) |
pmpailis
added
the
auto-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with the failing test was that we're having an assertion within the test suite that relies on 3 randomly generated integers. The assertion states that the sum should be a strictly positive number, whereas the integers are drawn from the
[0, 10]range.Since this seems to be only test-related, and IIUC is not an actual issue that we might have to deal with, in this PR we are adding small variance to one of the int variables in case all of them are 0 (+unmuting the test itself).
Closes #98706