Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register TopN status in plugin's writables #100874

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Oct 15, 2023

"node_failures": [
  {
    "type": "failed_node_exception",
    "reason": "Failed node [qpdSPb3yQkuDlsI9TH7a2g]",
    "node_id": "qpdSPb3yQkuDlsI9TH7a2g",
    "caused_by": {
      "type": "transport_serialization_exception",
      "reason": "Failed to deserialize response from handler",
      "caused_by": {
        "type": "illegal_argument_exception",
        "reason": "Unknown NamedWriteable [org.elasticsearch.compute.operator.Operator$Status][topn]"
      }
    }
  }
]

I hit this error when trying to retrieve ESQL tasks. The issue is that we forget to register NamedWritable for the status of TopN.

@dnhatn dnhatn added v8.11.1 >non-issue :Analytics/ES|QL AKA ESQL auto-backport-and-merge Automatically create backport pull requests and merge when ready labels Oct 16, 2023
@dnhatn dnhatn requested a review from nik9000 October 16, 2023 04:15
@dnhatn dnhatn marked this pull request as ready for review October 16, 2023 04:15
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticsearchmachine elasticsearchmachine added the Team:QL (Deprecated) Meta label for query languages team label Oct 16, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL)

Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Oct 16, 2023

Thanks, Costin!

@dnhatn dnhatn merged commit e4ea68a into elastic:main Oct 16, 2023
12 checks passed
@dnhatn dnhatn deleted the topn-status branch October 16, 2023 13:31
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.11

dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Oct 16, 2023
```
"node_failures": [
  {
    "type": "failed_node_exception",
    "reason": "Failed node [qpdSPb3yQkuDlsI9TH7a2g]",
    "node_id": "qpdSPb3yQkuDlsI9TH7a2g",
    "caused_by": {
      "type": "transport_serialization_exception",
      "reason": "Failed to deserialize response from handler",
      "caused_by": {
        "type": "illegal_argument_exception",
        "reason": "Unknown NamedWriteable [org.elasticsearch.compute.operator.Operator$Status][topn]"
      }
    }
  }
]
```

I hit this error when trying to retrieve ESQL tasks. The issue is that we forget
 to register NamedWritable for the status of TopN.
elasticsearchmachine pushed a commit that referenced this pull request Oct 16, 2023
```
"node_failures": [
  {
    "type": "failed_node_exception",
    "reason": "Failed node [qpdSPb3yQkuDlsI9TH7a2g]",
    "node_id": "qpdSPb3yQkuDlsI9TH7a2g",
    "caused_by": {
      "type": "transport_serialization_exception",
      "reason": "Failed to deserialize response from handler",
      "caused_by": {
        "type": "illegal_argument_exception",
        "reason": "Unknown NamedWriteable [org.elasticsearch.compute.operator.Operator$Status][topn]"
      }
    }
  }
]
```

I hit this error when trying to retrieve ESQL tasks. The issue is that we forget
 to register NamedWritable for the status of TopN.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-backport-and-merge Automatically create backport pull requests and merge when ready >non-issue Team:QL (Deprecated) Meta label for query languages team v8.11.1 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants