Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark legacy stack templates as deprecated #101476

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Mark legacy stack templates as deprecated #101476

merged 3 commits into from
Nov 8, 2023

Conversation

felixbarny
Copy link
Member

Depends on #101148.

@felixbarny felixbarny added >enhancement :Data Management/Indices APIs APIs to create and manage indices and templates labels Oct 27, 2023
@elasticsearchmachine elasticsearchmachine added external-contributor Pull request authored by a developer outside the Elasticsearch team v8.12.0 labels Oct 27, 2023
@elasticsearchmachine
Copy link
Collaborator

Hi @felixbarny, I've created a changelog YAML for you.

@felixbarny felixbarny force-pushed the mark-legacy-stack-component-templates-as-deprecated branch from 3f4cbb6 to 2e525f4 Compare November 3, 2023 07:01
@felixbarny felixbarny marked this pull request as ready for review November 3, 2023 07:01
@felixbarny felixbarny requested a review from a team as a code owner November 3, 2023 07:01
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Nov 3, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@dakrone
Copy link
Member

dakrone commented Nov 7, 2023

@elasticmachine update branch

dakrone
dakrone approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming CI is happy, thanks Felix

@felixbarny felixbarny merged commit 16cce1f into elastic:main Nov 8, 2023
13 checks passed
@felixbarny felixbarny deleted the mark-legacy-stack-component-templates-as-deprecated branch November 8, 2023 06:12
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Nov 8, 2023
@dakrone
Revert "Mark legacy stack templates as deprecated (elastic#101476)"
7529d92 
This reverts commit 16cce1f.
JVerwolf pushed a commit that referenced this pull request Nov 8, 2023
@dakrone @elasticmachine
Revert "Mark legacy stack templates as deprecated (#101476)" (#101935)
2ebd084 
* Revert "Mark legacy stack templates as deprecated (#101476)"

This reverts commit 16cce1f.

* Remove test that was part of revert conflict

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@felixbarny felixbarny mentioned this pull request Nov 13, 2023
Merged
elasticsearchmachine pushed a commit that referenced this pull request Nov 15, 2023
@felixbarny
Mark legacy stack templates as deprecated (#102081)
5f66c18 
Restores #101476 that was reverted in #101935.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakrone dakrone dakrone approved these changes

@eyalkoren eyalkoren Awaiting requested review from eyalkoren

Assignees

@felixbarny felixbarny

Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >enhancement external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management Meta label for data/management team v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixbarny @elasticsearchmachine @dakrone @elasticmachine