Cleanup redundant logger fields #101655
Merged
Cleanup redundant logger fields #101655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making loggers static that can be made static, removing redundant test loggers (we already have the correct per class logger in this.logger) and also removing some just unused loggers.
original-brownbear
added
>non-issue
:Core/Infra/Logging
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
thecoop
reviewed
Nov 1, 2023
server/src/main/java/org/elasticsearch/node/NodeConstruction.java
Outdated
Show resolved
Hide resolved
thecoop
reviewed
Nov 1, 2023
thecoop
reviewed
Nov 1, 2023
server/src/main/java/org/elasticsearch/env/NodeEnvironment.java
Outdated
Show resolved
Hide resolved
thecoop
reviewed
Nov 2, 2023
...c/internalClusterTest/java/org/elasticsearch/xpack/ssl/SSLReloadDuringStartupIntegTests.java
Outdated
Show resolved
Hide resolved
thecoop
reviewed
Nov 2, 2023
test/framework/src/main/java/org/elasticsearch/test/engine/MockEngineSupport.java
Outdated
Show resolved
Hide resolved
thecoop
reviewed
Nov 2, 2023
...repository-azure/src/main/java/org/elasticsearch/repositories/azure/AzureClientProvider.java
Outdated
Show resolved
Hide resolved
thecoop
approved these changes
Nov 2, 2023
|
Thanks Simon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some random finds, found two of these and figured I'd fix them all real quick: Making loggers static that can be made static, removing redundant test loggers (we already have the correct per class logger in this.logger) and also removing some just unused loggers.