Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit SearchResponse references from server metrics aggs ITs #101999

Merged

Conversation

original-brownbear
Copy link
Member

@original-brownbear original-brownbear commented Nov 10, 2023

Remove explicit references from org.elasticsearch.search.aggregations.metrics

closes #101766

Co-authored-by: Ignacio Vera ivera@apache.org

Remove explicit references from `org.elasticsearch.search.aggregations.metrics`
@original-brownbear original-brownbear added >test Issues or PRs that are addressing/adding tests :Search/Search Search-related issues that do not fall into other categories labels Nov 10, 2023
@elasticsearchmachine elasticsearchmachine added v8.12.0 Team:Search Meta label for search team labels Nov 10, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@original-brownbear
Copy link
Member Author

No review needed here this isn't my work, credit goes to Ignacio here, I reviewed this just fixed a single isolated merge conflict since he's out today to get this in :)

@original-brownbear original-brownbear added the auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Nov 10, 2023
@elasticsearchmachine elasticsearchmachine merged commit a30a835 into elastic:main Nov 10, 2023
13 checks passed
@original-brownbear original-brownbear deleted the metricsAggsAsserts2 branch November 10, 2023 17:09
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this pull request Nov 13, 2023
elastic#101999)

Remove explicit references from
`org.elasticsearch.search.aggregations.metrics`

closes elastic#101766 

Co-authored-by: Ignacio Vera <ivera@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants