Removing explicit SearchResponse usages in tests - v3 #102019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmpailis
added
>test
|
Pinging @elastic/es-search (Team:Search) |
pmpailis
removed
the
auto-merge
…earch-response-test-v3
78 tasks
|
@elasticmachine update branch |
| assertThat(item.getFailureMessage(), notNullValue()); | ||
| assertThat(item.getFailureMessage(), containsString("[test/6] couldn't be found")); | ||
| } finally { | ||
| if (response != null) { |
There was a problem hiding this comment.
Lets back this one out please, this should be resolved by adjusting the ref counting on MultiSearchResponse in production so this becomes a single .decRef(), not by us doing this manually in tests :)
There was a problem hiding this comment.
Yeap, makes sense. Was wondering whether we want to eliminate as many test instances as possible in this round and then revisit explicitly MultiSearchResponse when we have the decRef properly implement. Reverted.
pmpailis
added
the
auto-merge
|
@elasticmachine update branch |
davidkyle
pushed a commit
to davidkyle/elasticsearch
that referenced
this pull request
Nov 13, 2023
Tests covered in this PR: * `org.elasticsearch.percolator.PercolatorQuerySearchIT`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests covered in this PR:
org.elasticsearch.percolator.PercolatorQuerySearchIT