[ML] Remove all SearchResponse direct references from tests #102024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>test
|
Pinging @elastic/ml-core (Team:ML) |
benwtrent
changed the title
benwtrent
added
the
auto-merge
78 tasks
davidkyle
pushed a commit
to davidkyle/elasticsearch
that referenced
this pull request
Nov 13, 2023
Moving towards ref counted search responses, this removes all direct references to SearchResponse from ML tests. The remaining references in ML tests are for mocked search responses. Additionally, while making this change, I noticed there are multiple places in ML production code that have the `SearchResponse searchResponse = ` pattern. Meaning, once we refCount `SearchResponse`, those places will have to be updated as well (in a future PR). Related to: elastic#100966 Related to: elastic#99590
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving towards ref counted search responses, this removes all direct references to SearchResponse from ML tests.
The remaining references in ML tests are for mocked search responses.
Additionally, while making this change, I noticed there are multiple places in ML production code that have the
SearchResponse searchResponse =pattern. Meaning, once we refCountSearchResponse, those places will have to be updated as well (in a future PR).Related to: #100966
Related to: #99590