Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove explicit SearchResponse references from server bucket aggs (part1) #102035

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Remove explicit SearchResponse references from server bucket aggs (part1) #102035

merged 1 commit into from
Nov 11, 2023

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Nov 10, 2023

Remove explicit references from org.elasticsearch.search.aggregations.buckets

@iverase iverase added >test Issues or PRs that are addressing/adding tests :Search/Search Search-related issues that do not fall into other categories v8.12.0 labels Nov 10, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Nov 10, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@iverase iverase mentioned this pull request Nov 10, 2023
Closed
78 tasks
original-brownbear
original-brownbear approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iverase iverase merged commit 697dac2 into elastic:main Nov 11, 2023
13 checks passed
@iverase iverase deleted the bucketAggsAssert1 branch November 11, 2023 15:36
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this pull request Nov 13, 2023
@iverase @davidkyle
Remove explicit SearchResponse references from server bucket aggs (pa…
62a5a09 
…rt1) (elastic#102035)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@original-brownbear original-brownbear original-brownbear approved these changes

Assignees
No one assigned
Labels
:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iverase @elasticsearchmachine @original-brownbear