Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move LeakTracker to production code and use it in assertions around QuerySearchContext #102179

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Move LeakTracker to production code and use it in assertions around QuerySearchContext #102179

merged 1 commit into from
Nov 14, 2023

Commits on Nov 14, 2023

  1. Move LeakTracker to production code and use it in assertions around Q… 

    …uerySearchContext

Part of the ref counted search hits effort requires us to correctly ref
count `FetchSearchPhase`. This doesn't commit moves us one step in the
direction of doing so by adding testing that ensure that `QuerySearchContext`
is ref counted correctly and fixes one production code spot where it
wasn't (albeit that spot worked out for other reasons anyways).
This is done by moving the leak tracker to production code and making
use of it selectively in case assertions are enabled.
    @original-brownbear
    original-brownbear committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    c3fa0de View commit details
    Browse the repository at this point in the history