Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ref counting when using futures in AbstractClient #102498

Merged
merged 6 commits into from
Nov 23, 2023
Merged

Fix ref counting when using futures in AbstractClient #102498

merged 6 commits into from
Nov 23, 2023

Commits on Nov 22, 2023

  1. Fix ref counting when using futures in AbstractClient 

    We fundamentally need to increment the ref count by one before
assigning a ref counted value to a future result.
Otherwise, trasnsport actions will have to understand the specific
kind of listener they resolve and cannot decrement sent/consumed
transport messages themselves.
    @original-brownbear
    original-brownbear committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    6c07931 View commit details
    Browse the repository at this point in the history

  2. internal to the client

    @original-brownbear
    original-brownbear committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    18c2b00 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. assert only get once and safer ref counting

    @original-brownbear
    original-brownbear committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    094e854 View commit details
    Browse the repository at this point in the history

  2. tests

    @original-brownbear
    original-brownbear committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    8a63972 View commit details
    Browse the repository at this point in the history

  3. jee

    @original-brownbear
    original-brownbear committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    cd4fdd5 View commit details
    Browse the repository at this point in the history

  4. tests

    @original-brownbear
    original-brownbear committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    12fd464 View commit details
    Browse the repository at this point in the history