Fix ref counts for MultiSearchResponse not released in tests #102604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of the effort to fix search response leaks is to fix these. Fixed all that I could easily find in tests. Production changes incoming once the dependencies for those are fixed.
original-brownbear
added
>non-issue
:Search/Search
78 tasks
|
Pinging @elastic/es-search (Team:Search) |
DaveCTurner
approved these changes
Nov 24, 2023
|
Thanks David actually it shouldn't be many more 🤞 but let's see. Also some production stuff left here actually ..., but lets fix the other ref counting issues/PRs first before we can dive into those :) |
original-brownbear
added
the
auto-merge
timgrein
pushed a commit
to timgrein/elasticsearch
that referenced
this pull request
Nov 30, 2023
…#102604) Part of the effort to fix search response leaks is to fix these. Fixed all that I could easily find in tests. Production changes incoming once the dependencies for those are fixed. part of elastic#102030 but no fancy utility here like for search responses since we don't have so many use cases an none of them are tricky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the effort to fix search response leaks is to fix these. Fixed all that I could easily find in tests. Production changes incoming once the dependencies for those are fixed.
part of #102030 but no fancy utility here like for search responses since we don't have so many use cases an none of them are tricky.