Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline ActionType in RequestBuilder constructors #102800

Conversation

original-brownbear
Copy link
Member

These are always constant values. We can inline them everywhere to save code and easy removing the subclasses of ActionType going forward.

These are always constant values. We can inline them everywhere to save
code and easy removing the subclasses of ActionType going forward.
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was long :)
But LGTM

@original-brownbear
Copy link
Member Author

Thanks Lorenzo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Transport API Transport client API >non-issue Team:Core/Infra Meta label for core/infra team v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants