Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more leaked SearchResponse instances in tests #102822

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Fix more leaked SearchResponse instances in tests #102822

merged 1 commit into from
Nov 30, 2023

Conversation

original-brownbear
Copy link
Member

Couple more of these fixed for #102030

@original-brownbear original-brownbear added >test Issues or PRs that are addressing/adding tests :Search/Search Search-related issues that do not fall into other categories labels Nov 30, 2023
@elasticsearchmachine elasticsearchmachine added Team:Search Meta label for search team v8.12.0 labels Nov 30, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@original-brownbear original-brownbear mentioned this pull request Nov 30, 2023
Closed
78 tasks
iverase
iverase approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@iverase iverase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear
Copy link
Member Author

Thanks Ignacio!

@original-brownbear original-brownbear added the auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Nov 30, 2023
@elasticsearchmachine elasticsearchmachine merged commit a6c4445 into elastic:main Nov 30, 2023
15 checks passed
@original-brownbear original-brownbear deleted the fix-more-tests branch November 30, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iverase iverase iverase approved these changes

Assignees
No one assigned
Labels
auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@original-brownbear @elasticsearchmachine @iverase