Decref CacheFileRegion after read is done not before #102848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>bug
:Distributed/Snapshot/Restore
|
Hi @tlrx, I've created a changelog YAML for you. |
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
@tlrx only thing to fix is the title, CacheFileRegion is what you decrement here :) |
tlrx
changed the title
🤦🏻 Thanks for noticing! |
|
When assertions are enabled, could we fill regions with junk on release? That would make it easier to catch this kind of thing I think. |
|
CI failures are #102575 |
Probably, I take the point. Thanks for the suggestion! |
|
Thanks Armin! |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Dec 8, 2023
The CacheFileRegion instance is decref before the read operation is executed, meaning that the SharedBytes.IO instance can return to the pool of free regions, being polled and written by another thread for another cache file region, before the first read is effectively completed (and will return incorrect bytes).
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 8, 2023
The CacheFileRegion instance is decref before the read operation is executed, meaning that the SharedBytes.IO instance can return to the pool of free regions, being polled and written by another thread for another cache file region, before the first read is effectively completed (and will return incorrect bytes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CacheFileRegion instance is decref before the read operation is executed, meaning that the SharedBytes.IO instance can return to the pool of free regions, being polled and written for another cache file region by another thread, before the first read is effectively completed (and will return incorrect bytes).