Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable APM tracing when --with-apm-server is used #103268

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

pgomulka
Copy link
Contributor

when runtask (gradlew run) task is run with --with-apm-server apm tracing should also be enabled

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

when runtask (gradlew run) task is run with --with-apm-server
apm tracing should also be enabled
@pgomulka pgomulka added >non-issue :Core/Infra/Core Core issues without another label labels Dec 11, 2023
@pgomulka pgomulka self-assigned this Dec 11, 2023
@elasticsearchmachine elasticsearchmachine added v8.13.0 Team:Core/Infra Meta label for core/infra team labels Dec 11, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@ldematte
Copy link
Contributor

Seems quite straightforward, but I don't understand what is happening here. Can you elaborate?
This flag starts a mock APM server, so we also enable metrics, because it is convenient (we know there will be a mock server, so we can send metrics to it).
With this we are also enabling the agent; I suppose this was required too to complete the chain and was a miss, or is it something more?

@pgomulka
Copy link
Contributor Author

Seems quite straightforward, but I don't understand what is happening here. Can you elaborate?
This flag starts a mock APM server, so we also enable metrics, because it is convenient (we know there will be a mock server, so we can send metrics to it).
With this we are also enabling the agent; I suppose this was required too to complete the chain and was a miss, or is it something more?

telemetry.metrics.enabled", "true is a flag to enable apm metrics (it was there before, not touched in this PR)
tracing.apm.agent.enabled", "true is a flag to enable apm tracing. The name is misleading I agree, we did not change this due to BWC. It was previously disabled (not missed)
those are separate feature that can work independently.

perhaps we should work at some point to cleanup the old settings names

@ldematte
Copy link
Contributor

OK, so now when the mock server is enabled, we conveniently also enable both metrics and tracing (before it was metrics only). Unless they are explicitly set as disabled in the settings.
If so, LGTM

@pgomulka
Copy link
Contributor Author

OK, so now when the mock server is enabled, we conveniently also enable both metrics and tracing (before it was metrics only). Unless they are explicitly set as disabled in the settings.

yes :)

@pgomulka pgomulka merged commit 543919b into elastic:main Dec 11, 2023
6 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants