Fix search response leaks in datastreams and mustache modules #103532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the remaining test leaks in datastream and mustache. Mustache will require a separate PR to make the search template response classes properly ref-counted but we can prepare for that here already.
original-brownbear
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
78 tasks
original-brownbear
added
the
auto-merge
navarone-feekery
pushed a commit
to navarone-feekery/elasticsearch
that referenced
this pull request
Dec 22, 2023
…c#103532) Fixes the remaining test leaks in datastream and mustache. Mustache will require a separate PR to make the search template response classes properly ref-counted but we can prepare for that here already. for elastic#102030
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the remaining test leaks in datastream and mustache. Mustache will require a separate PR to make the search template response classes properly ref-counted but we can prepare for that here already.
for #102030