Fix SearchResponse leaks in REST and Enrich tests #103533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's in the title, fix a couple of tests here and there. Also, fix REST tests in particular and add a utility to cleanly read a SearchResponse from a REST response without leaking the parser.
original-brownbear
added
>test
78 tasks
|
Pinging @elastic/es-search (Team:Search) |
carlosdelest
approved these changes
Dec 19, 2023
original-brownbear
added
the
auto-merge
navarone-feekery
pushed a commit
to navarone-feekery/elasticsearch
that referenced
this pull request
Dec 22, 2023
It's in the title, fix a couple of tests here and there. Also, fix REST tests in particular and add a utility to cleanly read a SearchResponse from a REST response without leaking the parser. for elastic#102030
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's in the title, fix a couple of tests here and there. Also, fix REST tests in particular and add a utility to cleanly read a SearchResponse from a REST response without leaking the parser.
for #102030