Use ref-count aware chunked-xcontent listener in most spots #103803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a lot of spots where the search response wasn't yet handled by the ref-counting version of the listener. I figured, since all but 2 usages of the plain listener involved a ref counted (albeit noop) transport response anyway, I might as well mostly use that one to aid potential future refactoring.
original-brownbear
added
>non-issue
:Distributed/Network
78 tasks
elasticsearchmachine
added
Team:Distributed
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Thanks David! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a lot of spots where the search response wasn't yet handled by the ref-counting version of the listener. I figured, since all but 2 usages of the plain listener involved a ref counted (albeit noop) transport response anyway, I might as well mostly use that one to aid potential future refactoring.
For #102030