Fix incorrect assumptions about BytesReference in StateToProcessWriterHelper #103929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rHelper The logic here only works accidentally if the `source` is backed by a single `byte[]` with offset `0`. Fixed by using the `writeTo` API and just working on the bytes reference via its index handling to find the zero byte offset.
78 tasks
|
Pinging @elastic/ml-core (Team:ML) |
droberts195
approved these changes
Jan 4, 2024
|
npnp + thanks for the speedy review David! :) |
original-brownbear
added
the
auto-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic here only works accidentally if the
sourceis backed by a singlebyte[]with offset0.Fixed by using the
writeToAPI and just working on the bytes reference via its index handling to find the zero byte offset.Non issue since this isn't causing trouble right now but broke when I tried using this with sliced buffers for #102030