Introduce a noop, never-released ref counted constant #103931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for the search response pooling work. Also, the one usage in `ReleasableBytesReference` actually makes outright sense. We shouldn't be ref-counting on a global constant, that just needlessly introduces contention that isn't entirely obvious. This change required a couple tests to be adjusted where we were checking release mechanics on noop instances.
original-brownbear
added
>non-issue
:Distributed/Network
elasticsearchmachine
added
Team:Distributed
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
approved these changes
Jan 4, 2024
Co-authored-by: David Turner <david.turner@elastic.co>
|
Thanks David! |
original-brownbear
added
the
auto-merge
78 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for the search response pooling work. Also, the one usage in
ReleasableBytesReferenceactually makes outright sense. We shouldn't be ref-counting on a global constant, that just needlessly introduces contention that isn't entirely obvious. This change required a couple tests to be adjusted where we were checking release mechanics on noop instances.