Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more search response leaks in tests #103956

Conversation

original-brownbear
Copy link
Member

Some more mechanical fixing of leaked SearchResponse instances in test code.

Some more mechanical fixing of leaked SearchResponse instances.
@original-brownbear original-brownbear added >test Issues or PRs that are addressing/adding tests :Search/Search Search-related issues that do not fall into other categories labels Jan 5, 2024
@elasticsearchmachine elasticsearchmachine added v8.13.0 Team:Search Meta label for search team labels Jan 5, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

Copy link
Contributor

@iverase iverase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear
Copy link
Member Author

Thanks Ignacio!

@original-brownbear original-brownbear merged commit 80a9508 into elastic:main Jan 5, 2024
15 checks passed
@original-brownbear original-brownbear deleted the fix-random-search-response-leaks branch January 5, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants