Fix SearchResponse leak in MutableSearchResponse #104524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing a leak in how a `SearchResponse` is created in `MutableSearchResponse` as well as a couple obvious leaks in the tests for `AsyncSearchTask`. closes elastic#104491
original-brownbear
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
benwtrent
approved these changes
Jan 18, 2024
original-brownbear
added
the
auto-merge
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a leak in how a
SearchResponseis created inMutableSearchResponseas well as a couple obvious leaks in the tests forAsyncSearchTask.closes #104491
closes #104492
closes #104522
non-issue since this hasn't made it into any release yet
tip :) -> Review with whitespace hidden