Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SearchResponse leaks in cross cluster access tests #105039

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

slobodanadamovic
Copy link
Contributor

This one has been missed by #103239. It reproduces only in certain test conditions. The easiest to reproduce is to annotate the test with @Repeat(iterations = 100).

Resolves #105038

@slobodanadamovic slobodanadamovic added >test Issues or PRs that are addressing/adding tests :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC Team:Security Meta label for security team labels Feb 1, 2024
@slobodanadamovic slobodanadamovic self-assigned this Feb 1, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

Copy link
Contributor

@albertzaharovits albertzaharovits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for fixing!

@slobodanadamovic slobodanadamovic merged commit 7c2fdff into elastic:main Feb 2, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] CrossClusterAccessHeadersForCcsRestIT testCrossClusterAccessHeadersSentMultipleRemotes failing
3 participants