Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ThreadPool.Names#SAME #107249

Merged

Conversation

DaveCTurner
Copy link
Contributor

SAME is a distinguished threadpool name that callers could use to
obtain a special ExecutorService that runs tasks immediately, directly
on the calling thread. In fact there are no callers that use this name
any more, so we can remove it and all the associated special handling.

Relates #106279

`SAME` is a distinguished threadpool name that callers could use to
obtain a special `ExecutorService` that runs tasks immediately, directly
on the calling thread. In fact there are no callers that use this name
any more, so we can remove it and all the associated special handling.

Relates elastic#106279
@DaveCTurner DaveCTurner added >non-issue :Core/Infra/Core Core issues without another label v8.14.0 labels Apr 9, 2024
@DaveCTurner DaveCTurner requested a review from a team as a code owner April 9, 2024 08:20
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Apr 9, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (provided CI passes)

@DaveCTurner DaveCTurner added the auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Apr 9, 2024
@elasticsearchmachine elasticsearchmachine merged commit bdc9873 into elastic:main Apr 9, 2024
14 checks passed
@DaveCTurner DaveCTurner deleted the 2024/04/09/remove-SAME branch April 9, 2024 09:28
@DaveCTurner DaveCTurner restored the 2024/04/09/remove-SAME branch June 17, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants