Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround G1 bug for JDK 22 and 22.0.1 #108571

Merged
merged 2 commits into from
May 14, 2024

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented May 13, 2024

See https://bugs.openjdk.org/browse/JDK-8329528. The applied workaround was suggested on the linked issue, and was tested and confirmed to avoid the G1 bug.

See https://bugs.openjdk.org/browse/JDK-8329528. The applied workaround
was suggested on the linked issue, and was tested and confirmed to avoid
the G1 bug.
@rjernst rjernst added >bug :Core/Infra/CLI CLI utilities, scripts, and infrastructure labels May 13, 2024
@rjernst rjernst requested a review from a team as a code owner May 13, 2024 14:30
@rjernst rjernst requested a review from ChrisHegarty May 13, 2024 14:30
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team v8.15.0 labels May 13, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

Hi @rjernst, I've created a changelog YAML for you.

Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pr: 108571
summary: Workaround G1 bug for JDK 22 and 22.0.1
area: Infra/CLI
type: bug
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a bit of info in here for the release notes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is about the extent the changelog supports for details. The linked PR (this PR) has more details in the description.

Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 2

@rjernst rjernst merged commit b2bc951 into elastic:main May 14, 2024
15 checks passed
@rjernst rjernst deleted the jdk/workaround_g1_bug branch May 14, 2024 13:17
rjernst added a commit to rjernst/elasticsearch that referenced this pull request May 14, 2024
See https://bugs.openjdk.org/browse/JDK-8329528. The applied workaround
was suggested on the linked issue, and was tested and confirmed to avoid
the G1 bug.
rjernst added a commit to rjernst/elasticsearch that referenced this pull request May 14, 2024
See https://bugs.openjdk.org/browse/JDK-8329528. The applied workaround
was suggested on the linked issue, and was tested and confirmed to avoid
the G1 bug.
elasticsearchmachine pushed a commit that referenced this pull request May 14, 2024
See https://bugs.openjdk.org/browse/JDK-8329528. The applied workaround
was suggested on the linked issue, and was tested and confirmed to avoid
the G1 bug.
elasticsearchmachine pushed a commit that referenced this pull request May 14, 2024
See https://bugs.openjdk.org/browse/JDK-8329528. The applied workaround
was suggested on the linked issue, and was tested and confirmed to avoid
the G1 bug.
rjernst added a commit to rjernst/elasticsearch that referenced this pull request May 15, 2024
This commit re-bumps the bundled JDK to Java 22 now that we have
a tested workaround for the G1GC bug
(https://bugs.openjdk.org/browse/JDK-8329528).

relates elastic#108571
relates elastic#106987
rjernst added a commit that referenced this pull request May 15, 2024
This commit re-bumps the bundled JDK to Java 22 now that we have
a tested workaround for the G1GC bug
(https://bugs.openjdk.org/browse/JDK-8329528).

relates #108571
relates #106987
rjernst added a commit to rjernst/elasticsearch that referenced this pull request May 15, 2024
This commit re-bumps the bundled JDK to Java 22 now that we have
a tested workaround for the G1GC bug
(https://bugs.openjdk.org/browse/JDK-8329528).

relates elastic#108571
relates elastic#106987
rjernst added a commit to rjernst/elasticsearch that referenced this pull request May 15, 2024
This commit re-bumps the bundled JDK to Java 22 now that we have
a tested workaround for the G1GC bug
(https://bugs.openjdk.org/browse/JDK-8329528).

relates elastic#108571
relates elastic#106987
elasticsearchmachine pushed a commit that referenced this pull request May 15, 2024
This commit re-bumps the bundled JDK to Java 22 now that we have
a tested workaround for the G1GC bug
(https://bugs.openjdk.org/browse/JDK-8329528).

relates #108571
relates #106987
elasticsearchmachine pushed a commit that referenced this pull request May 16, 2024
* Update bundled JDK to Java 22 (again) (#108654)

This commit re-bumps the bundled JDK to Java 22 now that we have
a tested workaround for the G1GC bug
(https://bugs.openjdk.org/browse/JDK-8329528).

relates #108571
relates #106987

* copy main openjdk toolchain resolver

* use 2 lines for workaround

* fix test

* update adoptium test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Core/Infra/CLI CLI utilities, scripts, and infrastructure Team:Core/Infra Meta label for core/infra team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants