Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Cleanup meta field docs #10912

Merged
merged 1 commit into from
May 7, 2015
Merged

Docs: Cleanup meta field docs #10912

merged 1 commit into from
May 7, 2015

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Apr 30, 2015

Meta fields were locked down to not allow exotic options to the
underlying field types in #8143. This change fixes the docs
to no longer refer to the old settings.

closes #10879

@rjernst rjernst added >docs General docs changes v2.0.0-beta1 :Search Foundations/Mapping Index mappings, including merging and defining field types labels Apr 30, 2015
}
}
--------------------------------------------------
Note, even though the `_type` is not indexed, all the APIs still work
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, but it IS indexed, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! This was a mistake, I reworded the _type docs.

@clintongormley
Copy link

As a side note, shouldn't we remove the ability to configure store/index on timestamp? http://www.elastic.co/guide/en/elasticsearch/reference/master/mapping-timestamp-field.html#_store_index_2

@@ -5,15 +5,6 @@ The routing field allows to control the `_routing` aspect when indexing
data and explicit routing control is required.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a note saying that _routing is stored but not indexed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually looks like it is stored AND indexed

@rjernst
Copy link
Member Author

rjernst commented May 6, 2015

@clintongormley I pushed a new commit addressing your comments. For _timestamp we never locked it down because it is essentially a user field (the only way to add a NOW to a date field). I think we should continue looking at changing that separately.

Meta fields were locked down to not allow exotic options to the
underlying field types in elastic#8143. This change fixes the docs
to no longer refer to the old settings.

closes elastic#10879
@rjernst rjernst merged commit e29492c into elastic:master May 7, 2015
@rjernst rjernst deleted the fix/10879 branch May 7, 2015 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Update docs for mapping fields
3 participants