Fix automatic tracking of collapse with docvalue_fields #110103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>bug
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
|
Hi @benwtrent, I've created a changelog YAML for you. |
kderusso
approved these changes
Jun 25, 2024
| summary: Fix automatic tracking of collapse with `docvalue_fields` | ||
| area: Search | ||
| type: bug | ||
| issues: [] |
benwtrent
added
the
auto-merge
|
@elasticmachine update branch |
|
Hi @benwtrent, I've updated the changelog YAML for you. |
💚 Backport successful
|
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Jun 25, 2024
There were some optimizations that broke collapse fields automatically being added to `docvalue_fields` during the fetch phase. Consequently, users will get really weird errors like `unsupported_operation_exception`. This commit corrects the intended behavior of automatically including the collapse field in the docvalue_fields context during fetch if it isn't already included. closes: elastic#96510
benwtrent
added a commit
that referenced
this pull request
Jun 26, 2024
…10154) There were some optimizations that broke collapse fields automatically being added to `docvalue_fields` during the fetch phase. Consequently, users will get really weird errors like `unsupported_operation_exception`. This commit corrects the intended behavior of automatically including the collapse field in the docvalue_fields context during fetch if it isn't already included. closes: #96510
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some optimizations that broke collapse fields automatically being added to
docvalue_fieldsduring the fetch phase.Consequently, users will get really weird errors like
unsupported_operation_exception. This commit corrects the intended behavior of automatically including the collapse field in the docvalue_fields context during fetch if it isn't already included.closes: #96510