ESQL: Compute engine support for stateful grouping functions #112757
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,142 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| package org.elasticsearch.compute.aggregation; | ||
|
|
||
| import org.elasticsearch.compute.aggregation.blockhash.BlockHash; | ||
| import org.elasticsearch.compute.data.Block; | ||
| import org.elasticsearch.compute.data.BlockFactory; | ||
| import org.elasticsearch.compute.data.ElementType; | ||
| import org.elasticsearch.compute.data.IntVector; | ||
| import org.elasticsearch.compute.data.Page; | ||
| import org.elasticsearch.compute.operator.DriverContext; | ||
| import org.elasticsearch.compute.operator.EvalOperator; | ||
| import org.elasticsearch.core.Releasable; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| public record GroupingKey(AggregatorMode mode, Thing thing, BlockFactory blockFactory) implements EvalOperator.ExpressionEvaluator { | ||
| public interface Thing extends Releasable { | ||
| int extraIntermediateBlocks(); | ||
|
|
||
| Block evalRawInput(Page page); | ||
|
|
||
| Block evalIntermediateInput(BlockFactory blockFactory, Page page); | ||
|
|
||
| void fetchIntermediateState(BlockFactory blockFactory, Block[] blocks, int positionCount); | ||
|
|
||
| void replaceIntermediateKeys(BlockFactory blockFactory, Block[] blocks); | ||
| } | ||
|
|
||
| public interface Supplier { | ||
| Factory get(AggregatorMode mode); | ||
| } | ||
|
|
||
| public interface Factory { | ||
| GroupingKey apply(DriverContext context, int resultOffset); | ||
|
|
||
| ElementType intermediateElementType(); | ||
|
|
||
| GroupingAggregator.Factory valuesAggregatorForGroupingsInTimeSeries(int timeBucketChannel); | ||
| } | ||
|
|
||
| public static GroupingKey.Supplier forStatelessGrouping(int channel, ElementType elementType) { | ||
| return mode -> new Factory() { | ||
| @Override | ||
| public GroupingKey apply(DriverContext context, int resultOffset) { | ||
| return new GroupingKey(mode, new Load(channel, resultOffset), context.blockFactory()); | ||
| } | ||
|
|
||
| @Override | ||
| public ElementType intermediateElementType() { | ||
| return elementType; | ||
| } | ||
|
|
||
| @Override | ||
| public GroupingAggregator.Factory valuesAggregatorForGroupingsInTimeSeries(int timeBucketChannel) { | ||
| if (channel != timeBucketChannel) { | ||
| final List<Integer> channels = List.of(channel); | ||
| // TODO: perhaps introduce a specialized aggregator for this? | ||
| return (switch (intermediateElementType()) { | ||
| case BYTES_REF -> new ValuesBytesRefAggregatorFunctionSupplier(channels); | ||
| case DOUBLE -> new ValuesDoubleAggregatorFunctionSupplier(channels); | ||
| case INT -> new ValuesIntAggregatorFunctionSupplier(channels); | ||
| case LONG -> new ValuesLongAggregatorFunctionSupplier(channels); | ||
| case BOOLEAN -> new ValuesBooleanAggregatorFunctionSupplier(channels); | ||
| case FLOAT, NULL, DOC, COMPOSITE, UNKNOWN -> throw new IllegalArgumentException("unsupported grouping type"); | ||
| }).groupingAggregatorFactory(AggregatorMode.SINGLE); | ||
| } | ||
| return null; | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| public static List<BlockHash.GroupSpec> toBlockHashGroupSpec(List<GroupingKey.Factory> keys) { | ||
| List<BlockHash.GroupSpec> result = new ArrayList<>(keys.size()); | ||
| for (int k = 0; k < keys.size(); k++) { | ||
| result.add(new BlockHash.GroupSpec(k, keys.get(k).intermediateElementType())); | ||
| } | ||
| return result; | ||
| } | ||
|
|
||
| @Override | ||
| public Block eval(Page page) { | ||
| return mode.isInputPartial() ? thing.evalIntermediateInput(blockFactory, page) : thing.evalRawInput(page); | ||
| } | ||
|
|
||
| public int finishBlockCount() { | ||
|
There was a problem hiding this comment. Nit: We're calling this "finish", while in the aggregator it's "evaluate". Some reason to keep those names separated? From what I understand, the operation is nearly the same (?) |
||
| return mode.isOutputPartial() ? 1 + thing.extraIntermediateBlocks() : 1; | ||
| } | ||
|
|
||
| public void finish(Block[] blocks, IntVector selected, DriverContext driverContext) { | ||
| if (mode.isOutputPartial()) { | ||
| thing.fetchIntermediateState(driverContext.blockFactory(), blocks, selected.getPositionCount()); | ||
| } else { | ||
| thing.replaceIntermediateKeys(driverContext.blockFactory(), blocks); | ||
| } | ||
| } | ||
|
|
||
| public int extraIntermediateBlocks() { | ||
| return thing.extraIntermediateBlocks(); | ||
| } | ||
|
|
||
| @Override | ||
| public void close() { | ||
| thing.close(); | ||
| } | ||
|
|
||
| private record Load(int channel, int resultOffset) implements Thing { | ||
| @Override | ||
| public int extraIntermediateBlocks() { | ||
| return 0; | ||
| } | ||
|
|
||
| @Override | ||
| public Block evalRawInput(Page page) { | ||
| Block b = page.getBlock(channel); | ||
| b.incRef(); | ||
| return b; | ||
| } | ||
|
|
||
| @Override | ||
| public Block evalIntermediateInput(BlockFactory blockFactory, Page page) { | ||
| Block b = page.getBlock(resultOffset); | ||
| b.incRef(); | ||
| return b; | ||
| } | ||
|
|
||
| @Override | ||
| public void fetchIntermediateState(BlockFactory blockFactory, Block[] blocks, int positionCount) {} | ||
|
|
||
| @Override | ||
| public void replaceIntermediateKeys(BlockFactory blockFactory, Block[] blocks) {} | ||
|
|
||
| @Override | ||
| public void close() {} | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "Thing" the final name here?