Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowed warnings to the dot-prefix yaml tests #113560

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Sep 25, 2024

This adds the missing optional warning from the global legacy template

Relates to #113529 (doesn't close it yet until this has been unmuted, which won't happen until this change is backported to 8.16)

This adds the missing optional warning from the global legacy template

Relates to elastic#113529 (doesn't close it yet until this has been unmuted, which won't happen until this
change is backported to 8.16)
@dakrone dakrone added >test Issues or PRs that are addressing/adding tests :Data Management/Indices APIs APIs to create and manage indices and templates v8.16.0 v9.0.0 labels Sep 25, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Sep 25, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Contributor

@nielsbauman nielsbauman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - once you update the second index patterns list :)

…api-spec/test/dot_prefix/10_basic.yml

Co-authored-by: Niels Bauman <33722607+nielsbauman@users.noreply.github.com>
@dakrone
Copy link
Member Author

dakrone commented Sep 26, 2024

@elasticmachine update branch

@dakrone dakrone added auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport-and-merge Automatically create backport pull requests and merge when ready labels Sep 26, 2024
@elasticsearchmachine elasticsearchmachine merged commit d8a3215 into elastic:main Sep 26, 2024
15 checks passed
@dakrone dakrone deleted the add-allowed-warnings branch September 26, 2024 16:08
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

dakrone added a commit to dakrone/elasticsearch that referenced this pull request Sep 26, 2024
This adds the missing optional warning from the global legacy template

Relates to elastic#113529 (doesn't close it yet until this has been unmuted,
which won't happen until this change is backported to 8.16)
elasticsearchmachine pushed a commit that referenced this pull request Sep 26, 2024
This adds the missing optional warning from the global legacy template

Relates to #113529 (doesn't close it yet until this has been unmuted,
which won't happen until this change is backported to 8.16)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Sep 27, 2024
This was fixed in elastic#113560, but couldn't be unmuted
there due to it requiring backporting before it was fixed.

Resolves elastic#113529
elasticsearchmachine pushed a commit that referenced this pull request Sep 30, 2024
This was fixed in #113560,
but couldn't be unmuted there due to it requiring backporting before it
was fixed.

Resolves #113529
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Data Management/Indices APIs APIs to create and manage indices and templates Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants