-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add allowed warnings to the dot-prefix yaml tests #113560
Merged
elasticsearchmachine
merged 3 commits into
elastic:main
from
dakrone:add-allowed-warnings
Sep 26, 2024
Merged
Add allowed warnings to the dot-prefix yaml tests #113560
elasticsearchmachine
merged 3 commits into
elastic:main
from
dakrone:add-allowed-warnings
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the missing optional warning from the global legacy template Relates to elastic#113529 (doesn't close it yet until this has been unmuted, which won't happen until this change is backported to 8.16)
dakrone
added
>test
Issues or PRs that are addressing/adding tests
:Data Management/Indices APIs
APIs to create and manage indices and templates
v8.16.0
v9.0.0
labels
Sep 25, 2024
elasticsearchmachine
added
the
Team:Data Management
Meta label for data/management team
label
Sep 25, 2024
Pinging @elastic/es-data-management (Team:Data Management) |
nielsbauman
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - once you update the second index patterns list :)
.../dot-prefix-validation/src/yamlRestTest/resources/rest-api-spec/test/dot_prefix/10_basic.yml
Outdated
Show resolved
Hide resolved
…api-spec/test/dot_prefix/10_basic.yml Co-authored-by: Niels Bauman <33722607+nielsbauman@users.noreply.github.com>
@elasticmachine update branch |
dakrone
added
auto-merge
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
auto-backport-and-merge
Automatically create backport pull requests and merge when ready
labels
Sep 26, 2024
💚 Backport successful
|
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Sep 26, 2024
This adds the missing optional warning from the global legacy template Relates to elastic#113529 (doesn't close it yet until this has been unmuted, which won't happen until this change is backported to 8.16)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 26, 2024
This adds the missing optional warning from the global legacy template Relates to #113529 (doesn't close it yet until this has been unmuted, which won't happen until this change is backported to 8.16) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Sep 27, 2024
This was fixed in elastic#113560, but couldn't be unmuted there due to it requiring backporting before it was fixed. Resolves elastic#113529
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport-and-merge
Automatically create backport pull requests and merge when ready
auto-merge
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Data Management/Indices APIs
APIs to create and manage indices and templates
Team:Data Management
Meta label for data/management team
>test
Issues or PRs that are addressing/adding tests
v8.16.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the missing optional warning from the global legacy template
Relates to #113529 (doesn't close it yet until this has been unmuted, which won't happen until this change is backported to 8.16)