ResourceWatcher: Rename settings to prevent watcher clash #11359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| highMonitor = new ResourceMonitor(interval, Frequency.HIGH); | ||
|
|
||
| logDeprecatedSetting("watcher.enabled", "resource.reload.enabled"); |
There was a problem hiding this comment.
Is this really a deprecation, or should it be an error? Deprecation to me implies the old settings still work, but it seems like above only the new setting works?
There was a problem hiding this comment.
You are right, deprecated should mean, that the setting still works. I added a logRemovedSetting() to log that this setting has been removed. Given the minority of this setting being changed, it is safe to be removed.
However after talking with clint about this, we need to decide on each case, if we want to support features/settings and log their deprecation or their removal.
spinscale
force-pushed
the
1505-watcher-interval-rename
branch
from
8552121
to
f616571
Compare
|
LGTM |
spinscale
force-pushed
the
1505-watcher-interval-rename
branch
from
f616571
to
664986b
Compare
The ResourceWatcher used settings prefixed `watcher.`, which potentially could clash with the watcher plugin. In order to prevent confusion, the settings have been renamed to `resource.reload` prefixes. This also uses the deprecation logging infrastructure introduced in elastic#11033 to log deprecated settings and their alternative at startup. Closes elastic#11175
spinscale
force-pushed
the
1505-watcher-interval-rename
branch
from
664986b
to
3bda78e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ResourceWatcher used settings prefixed
watcher., whichpotentially could clash with the watcher plugin.
In order to prevent confusion, the settings have been renamed to
resource.reloadprefixes.This also uses the deprecation logging infrastructure introduced
in #11033 to log deprecated settings and their alternative at
startup.
Closes #11175