Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Handle parsing ingest processors where definition is not a object #113697

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

davidkyle
Copy link
Member

ML does shallow parsing of ingest pipelines to find which models are used in them. The code contained an assumption that each processor definition was a object, for a script processor this is not the case.

The error came from an cast to (Map<String, Object>) which is now deferred to later in the processing with extra checks.

Closes #113615

@davidkyle davidkyle added >bug :ml Machine learning auto-backport-and-merge Automatically create backport pull requests and merge when ready v8.16.0 v9.0.0 v8.15.3 labels Sep 27, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Sep 27, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @davidkyle, I've created a changelog YAML for you.

@davidkyle
Copy link
Member Author

@elasticmachine run buildkite/docs-build-pr

@davidkyle
Copy link
Member Author

@elasticmachine update branch

@davidkyle davidkyle merged commit dc62810 into elastic:main Oct 1, 2024
15 of 16 checks passed
@davidkyle davidkyle deleted the fix-parsing-ingest-proc-error branch October 1, 2024 08:09
davidkyle added a commit to davidkyle/elasticsearch that referenced this pull request Oct 1, 2024
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x
8.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready >bug :ml Machine learning Team:ML Meta label for the ML team v8.15.3 v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elasticsearch accepts script processors that are strings and not map
4 participants