Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce field names do not contain dot #12068

Merged
merged 1 commit into from
Jul 7, 2015

Commits on Jul 7, 2015

  1. Mappings: Enforce field names do not contain dot

    Field names containing dots can cause problems. For example, @jpountz
    made this recreation which cause no error, but can result in a
    serialization exception if the type already exists:
    https://gist.github.com/jpountz/8c66817e00a322b81f85
    
    But this is not just a potential conflict. It also has larger problems,
    since only the leaf mapper is created. The intermediate "foo" object
    field would not exist if only "foo.bar" was in the mappings.
    
    This change forbids the use of dots in field names. It also
    fixes an issue with passing through the update_all_types setting,
    which was always set to true whenever a type already existed (!).
    
    I do not think we should worry about backwards compatibility here. This
    should be a hard break (and added to the migration plugin).
    rjernst committed Jul 7, 2015
    Configuration menu
    Copy the full SHA
    aed1f68 View commit details
    Browse the repository at this point in the history