-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query DSL: deprecate _name and boost in short variants of queries #12966
Query DSL: deprecate _name and boost in short variants of queries #12966
Conversation
LGTM |
4c21b7f
to
cd99e34
Compare
cd99e34
to
8b804d1
Compare
8b804d1
to
88631a2
Compare
Turns out that using I made a little adjustment to |
Can you add unit tests for toCamelCase given the changes you made? |
88631a2
to
42e55c4
Compare
done! are we sure this change is ok? I am a bit afraid of the consequences it might have, that we may not realize at the moment. |
This might only have bad impact on camel case, which I'm not too scared to break as none of our examples promotes it and it is on the way out (#8988). |
…egistered Closes elastic#8991 Closes elastic#13058
As discussed in elastic#11744 this is the last step to unify parsing of boost and _name. Those fields are supported only in long version of queries, while we sometimes parse them when wwe shouldn't, inconsistently. Closes elastic#11744 Closes elastic#12966
42e55c4
to
0384f0a
Compare
As discussed in elastic#11744 this is the last step to unify parsing of boost and _name. Those fields are supported only in long version of queries, while we sometimes parse them when wwe shouldn't, inconsistently. Closes elastic#11744 Closes elastic#12966
As discussed in #11744 this is the last step to unify parsing of boost and _name. Those fields are supported only in long version of queries, while we sometimes parse them when wwe shouldn't, inconsistently.
Closes #11744