Add PathHierarchy type back to path_hierarchy tokenizer for backward compatibility with 1.x #15785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
added
>bug
:Search Relevance/Analysis
|
Is there a way that we could only support it for indices created before 2.0 to ensure that new indices will use the lowercase version? |
|
Maybe we could register a subclass of PathHierarchyTokenizerFactory whose constructor fails if the version in the index settings is >= 2.0? The error message could even point to the replacement to use? |
|
Hmm after all we will have to do it for others analysis components (eg. edgeNGram) so let's push it as-is and work on a migration path as part of #8988 |
ywelsch
force-pushed
the
fix/path-hierarchy-type
branch
from
3999895
to
3cac1ae
Compare
…compatibility with 1.x Closes elastic#15785
ywelsch
force-pushed
the
fix/path-hierarchy-type
branch
from
3cac1ae
to
de6dfe1
Compare
ywelsch
pushed a commit
that referenced
this pull request
Jan 6, 2016
Add PathHierarchy type back to path_hierarchy tokenizer for backward compatibility with 1.x
ywelsch
pushed a commit
that referenced
this pull request
Jan 6, 2016
…compatibility with 1.x Closes #15785
ywelsch
pushed a commit
that referenced
this pull request
Jan 6, 2016
…compatibility with 1.x Closes #15785
ywelsch
pushed a commit
that referenced
this pull request
Jan 6, 2016
…compatibility with 1.x Closes #15785
ywelsch
pushed a commit
that referenced
this pull request
Jan 6, 2016
…compatibility with 1.x Closes #15785
|
@ywelsch this went into 2.2 as well can you label it accordingly? |
|
@s1monw done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #15756