Teach reindex to stop when cancelled #16613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * The reason the task was cancelled or null if it hasn't been cancelled. | ||
| */ | ||
| public String getReasonCancelled() { |
There was a problem hiding this comment.
may want to annotate with @Nullable
|
@dakrone I did all the things! |
|
LGTM, thanks Nik! |
nik9000
force-pushed
the
reindex_cancel
branch
from
909cfd0
to
33f15f2
Compare
All we do is check the cancelled flag and stop the request at a few key points. Adds the cancellation cause to the status so any request that is cancelled but doesn't die can be seen in the task list.
nik9000
force-pushed
the
reindex_cancel
branch
from
33f15f2
to
30107b4
Compare
lcawl
added
:Distributed/CRUD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All we do is check the cancelled flag and stop the request at a few key
points.
Adds the cancellation cause to the status so any request that is cancelled
but doesn't die can be seen in the task list.