Combine node name and task id into single string task id #16744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imotov
added
>feature
review
v5.0.0-alpha1
:Distributed/Task Management
|
@imotov so what seems weird about this to me is the way it reads: |
|
@dakrone I agree, do you have a suggestion for the name? |
| if (Strings.hasLength(taskId)) { | ||
| String[] s = Strings.split(taskId, ":"); | ||
| if (s == null || s.length != 2) { | ||
| throw new IllegalArgumentException("malformed task id" + taskId); |
|
Left some comments that are mostly minor :) |
|
@dakrone pushed the changes to address your comments. |
|
LGTM |
This commit changes the URL for task operations from `/_tasks/{nodeId}/{taskId}` to `/_tasks/{taskId}`, where `{taskId}` has a form of nodeid:id
imotov
force-pushed
the
change-tasks-rest-api
branch
from
db434ea
to
d6af669
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the URL for task operations from
/_tasks/{nodeId}/{taskId}to/_tasks/{taskId}, where{taskId}has a form ofnodeid:id