Deprecate camelCase settings magic #17875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking up settings currently falls back to adjusting the setting key to camelCase, and then looking at the parsed settings keys again. This adds deprecation logging to that case. While in 5.0 settings validation will handle most of these cases, there stills exists some code (eg analysis providers) which lookup settings directly on the Settings object. see elastic#8988
Closed
|
LGTM |
| String camelKey = toCamelCase(key); | ||
| if (key.equals(camelKey)) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
we don't need to compare keys here and could just rely on the lookup returning a non-null value?
|
LGTM |
clintongormley
added
:Core/Infra/Settings
rjernst
added a commit
that referenced
this pull request
Apr 21, 2016
Deprecate camelCase settings magic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking up settings currently falls back to adjusting the setting key to
camelCase, and then looking at the parsed settings keys again. This adds
deprecation logging to that case. While in 5.0 settings validation will
handle most of these cases, there stills exists some code (eg analysis
providers) which lookup settings directly on the Settings object.
see #8988