Process dynamic templates in order. #18638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
added
review
:Search Foundations/Mapping
| if (builder != null) { | ||
| return builder; | ||
| } | ||
| } |
There was a problem hiding this comment.
This code was initially added to fix #1418. But I checked and the bug does not reproduce without this block of code with recent versions of Jackson.
|
I looked at it and I think I understand what's going on so LGTM but I think @rjernst should also look |
|
LGTM too |
When calling `findTemplateBuilder(context, currentFieldName, "text", null)`, elasticsearch ignores all templates that have a `match_mapping_type` set since no dynamic type is provided (the last parameter, which is null in that case). So this should only be called _last_. Otherwise, if a path-based template matches, it will have precedence over all type-based templates. Closes elastic#18625
jpountz
force-pushed
the
fix/process_templates_in_order
branch
from
d2994b5
to
9570fea
Compare
jpountz
added a commit
that referenced
this pull request
May 31, 2016
When calling `findTemplateBuilder(context, currentFieldName, "text", null)`, elasticsearch ignores all templates that have a `match_mapping_type` set since no dynamic type is provided (the last parameter, which is null in that case). So this should only be called _last_. Otherwise, if a path-based template matches, it will have precedence over all type-based templates. Closes #18625
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
findTemplateBuilder(context, currentFieldName, "text", null),elasticsearch ignores all templates that have a
match_mapping_typeset sinceno dynamic type is provided (the last parameter, which is null in that case).
So this should only be called last. Otherwise, if a path-based template
matches, it will have precedence over all type-based templates.
Closes #18625
Closes #2401