[TEST] Fix tests that rely on assumption that data dirs are removed after index deletion acknowledged #18681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Asserts that there are no files in the specified path | ||
| */ | ||
| public void assertPathHasBeenCleared(Path path) throws Exception { | ||
| public void assertPathHasBeenCleared(Path path) { |
There was a problem hiding this comment.
is this always used in an assertBusy context? wonder if we should add it here. This can be suprising...
There was a problem hiding this comment.
At the moment it's only used in these (few) integration tests. I was debating this as well, but I think the method is also useful in unit tests.
There was a problem hiding this comment.
we can maybe have an assertPathHasBeenCleared variant? then people will hopefully see both and choose :)
There was a problem hiding this comment.
you mean assertBusyPathHasBeenCleared?
|
I left one suggestion/question . Feel free to push if it doesn't makes sense. |
…fter index deletion acknowledged Relates to elastic#18602
ywelsch
force-pushed
the
fix/tests-index-deletion
branch
from
abc2ff1
to
37adcbe
Compare
|
Thanks for reviewing @bleskes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #18602