Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some issues with painless's strings #22393

Merged
merged 3 commits into from
Jan 6, 2017
Merged

Fix some issues with painless's strings #22393

merged 3 commits into from
Jan 6, 2017

Commits on Jan 6, 2017

  1. Fix some issues with painless's strings 

    1. Escape sequences we're working. For example `\\` is now correctly
interpreted as `\` instead of `\\`. Same with `\'` being `'` and
`\"` being `"`.
2. `'` delimited strings weren't allowed to contain `"`s but it looked
like they were intended to support it. Now they do.
3. Improves the error message when the script contains an invalid
escape sequence inside a string to include a list of the valid
escape sequences.

Closes elastic#22372
    @nik9000
    nik9000 committed Jan 6, 2017
    Configuration menu
    Copy the full SHA
    a0d772b View commit details
    Browse the repository at this point in the history

  2. Switch from string replace to stringbuilder

    @nik9000
    nik9000 committed Jan 6, 2017
    Configuration menu
    Copy the full SHA
    96c798e View commit details
    Browse the repository at this point in the history

  3. Assert strings have quotes

    @nik9000
    nik9000 committed Jan 6, 2017
    Configuration menu
    Copy the full SHA
    6648937 View commit details
    Browse the repository at this point in the history