Remove some more ParseFieldMatcher usages #22571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nik9000 This should be the second last PR on this topic, next one will be the actual removal I think. |
nik9000
approved these changes
Jan 12, 2017
| ADD_PARSER.declareField(AliasActions::routing, p -> p.text(), new ParseField("routing"), ValueType.INT); | ||
| ADD_PARSER.declareField(AliasActions::indexRouting, p -> p.text(), new ParseField("index_routing"), ValueType.INT); | ||
| ADD_PARSER.declareField(AliasActions::searchRouting, p -> p.text(), new ParseField("search_routing"), ValueType.INT); | ||
| ADD_PARSER.declareField(AliasActions::routing, XContentParser::text, new ParseField("routing"), ValueType.INT); |
| static { | ||
| PARSER.declareField((parser, request, parseFieldMatcherSupplier) -> | ||
| request.getShrinkIndexRequest().settings(parser.map()), | ||
| PARSER.declareField((parser, request, parseFieldMatcherSupplier) -> request.getShrinkIndexRequest().settings(parser.map()), |
There was a problem hiding this comment.
s/parseFieldMatcherSupplier/context/ ? Or is there a version of this method without context?
There was a problem hiding this comment.
leftover thanks for finding it.
javanna
force-pushed
the
enhancement/remove_parse_field_matcher_usages_5
branch
from
81ec2bf
to
6099ef4
Compare
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Jan 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some more ParseFieldMatcher usages
Relates to #19552
Relates to #22130