Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify summary description #23794

Merged
merged 2 commits into from
Mar 29, 2017
Merged

Clarify summary description #23794

merged 2 commits into from
Mar 29, 2017

Conversation

GlenRSmith
Copy link
Contributor

Resolves #23793

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this, I left a suggestion.

request on. By default, the operation is randomized between the shard
replicas.
Controls a `preference` of which shard copies on which to execute the
search. By default, the operation is randomized among the primary
Copy link
Member

@jasontedor jasontedor Mar 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can also use the terminology "shard copies" that you used in the first sentence, I like it.

@jasontedor jasontedor merged commit ca26e82 into 5.3 Mar 29, 2017
jasontedor pushed a commit that referenced this pull request Mar 29, 2017
This commit clarifies the preference docs regarding the explanation of
how operations are routed by default. In particular, the previous use of
"shard replicas" was confusing as it could imply an operation would only
be routed to replicas by default.

Relates #23794
@jasontedor jasontedor deleted the GlenRSmith-patch-4 branch March 29, 2017 16:56
@jasontedor
Copy link
Member

Thanks @GlenRSmith.

jasontedor pushed a commit that referenced this pull request Mar 29, 2017
This commit clarifies the preference docs regarding the explanation of
how operations are routed by default. In particular, the previous use of
"shard replicas" was confusing as it could imply an operation would only
be routed to replicas by default.

Relates #23794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants